cellSpurs: Implement ShutdownTaskset and WorkloadFlagReceiver2 #13916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
commented
May 24, 2023
Nekotekina
reviewed
May 24, 2023
rpcs3/Emu/Cell/Modules/cellSpurs.cpp
Outdated
| { | ||
| UNIMPLEMENTED_FUNC(cellSpurs); | ||
| return CELL_OK; | ||
| cellSpurs.warning("_cellSpursWorkloadFlagReceiver2(spurs=*0x%x, wid=%d, is_set=%d, print_debug_output=0%d)", spurs, wid, is_set, print_debug_output); |
Megamouse
reviewed
May 24, 2023
Comment on lines
+3191
to
+3204
| if (is_set) | ||
| { | ||
| if (FlagReceiver == 0xff) | ||
| { | ||
| FlagReceiver = static_cast<u8>(wid); | ||
| } | ||
| } | ||
| else | ||
| { | ||
| if (FlagReceiver == wid) | ||
| { | ||
| FlagReceiver = 0xff; | ||
| } | ||
| } |
There was a problem hiding this comment.
this seems redundant.
can't you just set FlagReceiver in the scopes above ?
There was a problem hiding this comment.
I just seen it and they way it is is much more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.